Skip to content

tests: Add ISM330DL temperature to multidriver comparison scenario.#122

Merged
nedseb merged 2 commits intofix/ism330dl-temp-calibrationfrom
fix/temp-comparison-ism330dl
Mar 14, 2026
Merged

tests: Add ISM330DL temperature to multidriver comparison scenario.#122
nedseb merged 2 commits intofix/ism330dl-temp-calibrationfrom
fix/temp-comparison-ism330dl

Conversation

@nedseb
Copy link
Copy Markdown
Contributor

@nedseb nedseb commented Mar 14, 2026

Closes #101

Summary

Add ISM330DL temperature sensor to the multidriver temperature comparison scenario:

Depends on

Test plan

  • Run hardware temperature comparison tests with STeaMi board connected:

    python3 -m pytest tests/ --port /dev/ttyACM0 -k "temperature and comparison" -s -v

Test results

======================================================= test session starts ========================================================
platform linux -- Python 3.13.7, pytest-8.3.5, pluggy-1.5.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /home/nedjar/sandbox/micropython-steami-lib
configfile: pytest.ini
plugins: typeguard-4.4.2
collected 199 items / 195 deselected / 4 selected                                                                                  

tests/test_scenarios.py::test_scenario[Temperature comparison (all sensors)/Read all temperature sensors/hardware] --- Temperature Comparison ---
  WSEN-HIDS   : 27.97 C
  LIS2MDL     : 24.5 C
  WSEN-PADS   : 25.61 C
  HTS221      : 27.82 C
  ISM330DL    : 26.04 C
  Spread: 2.36 C
PASSED
tests/test_scenarios.py::test_scenario[Temperature comparison (all sensors)/Temperature spread with barometer/hardware] HTS221: 27.97 C  |  WSEN-PADS: 27.06 C  |  Spread: 0.91 C
PASSED
tests/test_scenarios.py::test_scenario[Temperature comparison (all sensors)/Offset-align all sensors to WSEN-HIDS reference/hardware] --- Before offset alignment ---
  WSEN-HIDS (ref): 27.79 C
  HTS221:          27.79 C
  WSEN-PADS:       27.11 C
  LIS2MDL:         24.5 C
  ISM330DL:        26.08 C
  Spread: 3.29 C
--- After offset alignment ---
  WSEN-HIDS (ref): 27.79 C
  HTS221:          27.79 C
  WSEN-PADS:       27.79 C
  LIS2MDL:         27.79 C
  ISM330DL:        27.79 C
  Spread: 0.0 C
PASSED
tests/test_scenarios.py::test_scenario[Temperature comparison (all sensors)/Temperature values feel correct/hardware]   [MANUAL] Les températures lues sont-elles cohérentes entre elles et avec l'ambiance ? [Entree=oui / Echap=non] 
PASSED

================================================ 4 passed, 195 deselected in 43.00s ================================================

@nedseb nedseb requested a review from Copilot March 14, 2026 15:38
@nedseb nedseb self-assigned this Mar 14, 2026
@nedseb nedseb added enhancement New feature or request test labels Mar 14, 2026
@nedseb nedseb linked an issue Mar 14, 2026 that may be closed by this pull request
3 tasks
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the ISM330DL temperature sensor to the multidriver temperature comparison board scenario, extending both the reading and offset-alignment tests.

Changes:

  • Added ism330dl to the drivers list and sys.path in both test scripts
  • Added ISM330DL temperature reading and offset alignment logic following the existing pattern for other sensors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nedseb nedseb merged commit 6851b0f into fix/ism330dl-temp-calibration Mar 14, 2026
@nedseb nedseb deleted the fix/temp-comparison-ism330dl branch March 14, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests: Add ISM330DL temperature to multidriver comparison scenario.

2 participants